Closed sergeyberezansky closed 3 days ago
This stack of pull requests is managed by Graphite. Learn more about stacking.
Join @sergeyberezansky and the rest of your teammates on Graphite
1 reviewer was added to this PR based on Sergey Berezansky's automation.
TL;DR
Added "sync,async" to mutually exclusive mount options and optimized mount handling in the CSI driver.
What changed?
values.yaml
.nfsMounter
to remove themountMap
and associated locking mechanism.NewMount
method to create a newnfsMount
object on each call.mountWithOptions
to merge mutually exclusive options.unmountWithOptions
to directly use the new mount object.NodePublishVolume
to defer unmounting of the parent filesystem.NodeUnpublishVolume
.How to test?
Why make this change?
This change aims to improve the handling of mount options and simplify the mount management process. By adding "sync" and "async" to the mutually exclusive options, we prevent potential conflicts in mount configurations, which might be caused by translating WekaFS mount options to NFS mount options. The refactoring of the
nfsMounter
removes the need for a complex mount map and associated locking, which should lead to better performance and reduced complexity. These changes should result in more reliable and efficient volume mounting and unmounting operations in the CSI driver.