weka / tools

GNU General Public License v3.0
20 stars 8 forks source link

Adding check to validate that Numa is set to NPS4 #296

Open nfelsen opened 5 months ago

nfelsen commented 5 months ago
bash -x scripts.d/default/201_checknps4.sh
+ DESCRIPTION='Check if NUMA is set to NPS4'
+ SCRIPT_TYPE=parallel
++ lscpu
++ awk '/^NUMA node\(s):/ { print $3 }'
+ nps_value=4
+ '[' 4 -eq 4 ']'
+ echo 'NUMA is set to NPS4 on s10sn0001.us-smf12.baremetal.cssp.tzla.net'
NUMA is set to NPS4 on s10sn0001.us-smf12.baremetal.cssp.tzla.net
+ ret=0
+ exit 0
vince-weka commented 5 months ago

We normally recommend NPS=1; why NPS=4?

Also, this only applies only to AMD processors, right? Should add a check for that. Maybe have a WARN if not NPS=4?

nfelsen commented 5 months ago

We normally recommend NPS=1; why NPS=4?

Also, this only applies only to AMD processors, right? Should add a check for that. Maybe have a WARN if not NPS=4?

I was asking our account manager if Weka recommends NPS4 to all customers and he said yes, that's why I created that PR (since I had the code for my own purpose) but if it's not the case, I'll close my PR.

WRT to Intel vs AMD, we use AMD for all Weka servers, I don't know if the value should be different for Intel but the regex is the same on Intel CPUs I believe:

~$ lscpu
Architecture:          x86_64
CPU op-mode(s):        32-bit, 64-bit
Byte Order:            Little Endian
CPU(s):                48
On-line CPU(s) list:   0-47
Thread(s) per core:    2
Core(s) per socket:    12
Socket(s):             2
NUMA node(s):          2
Vendor ID:             GenuineIntel
CPU family:            6
Model:                 79
Model name:            Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz
Stepping:              1
CPU MHz:               1201.163
CPU max MHz:           2900.0000
CPU min MHz:           1200.0000
BogoMIPS:              4401.24
Virtualization:        VT-x
L1d cache:             32K
L1i cache:             32K
L2 cache:              256K
L3 cache:              30720K
NUMA node0 CPU(s):     0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46
NUMA node1 CPU(s):     1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47
Flags:                 fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti ssbd ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm rdt_a rdseed adx smap intel_pt xsaveopt cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts md_clear flush_l1d
vince-weka commented 5 months ago

Part of the issue is that Intel servers don’t have an NPS setting - that’s an AMD-specific thing.We have a tool that sets the bios (bios_tool), and the default setting is NPS=1.   I don’t know where your account team got that we recommend NPS=4…Vince FlemingProduct @. ­W www.weka.io ­  ­On Mar 25, 2024, at 8:41 PM, Nathaniel Felsen @.> wrote:

We normally recommend NPS=1; why NPS=4? Also, this only applies only to AMD processors, right? Should add a check for that. Maybe have a WARN if not NPS=4?

I was asking our account manager if Weka recommends NPS4 to all customers and he said yes, that's why I created that PR (since I had the code for my own purpose) but if it's not the case, I'll close my PR. WRT to Intel vs AMD, we use AMD for all Weka servers, I don't know if the value should be different for Intel but the regex is the same on Intel CPUs I believe: ~$ lscpu Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Byte Order: Little Endian CPU(s): 48 On-line CPU(s) list: 0-47 Thread(s) per core: 2 Core(s) per socket: 12 Socket(s): 2 NUMA node(s): 2 Vendor ID: GenuineIntel CPU family: 6 Model: 79 Model name: Intel(R) Xeon(R) CPU E5-2650 v4 @ 2.20GHz Stepping: 1 CPU MHz: 1201.163 CPU max MHz: 2900.0000 CPU min MHz: 1200.0000 BogoMIPS: 4401.24 Virtualization: VT-x L1d cache: 32K L1i cache: 32K L2 cache: 256K L3 cache: 30720K NUMA node0 CPU(s): 0,2,4,6,8,10,12,14,16,18,20,22,24,26,28,30,32,34,36,38,40,42,44,46 NUMA node1 CPU(s): 1,3,5,7,9,11,13,15,17,19,21,23,25,27,29,31,33,35,37,39,41,43,45,47 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl vmx smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 cdp_l3 invpcid_single pti ssbd ibrs ibpb stibp tpr_shadow vnmi flexpriority ept vpid fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm cqm rdt_a rdseed adx smap intel_pt xsaveopt cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local dtherm ida arat pln pts md_clear flush_l1d

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>