search

weka / tools

GNU General Public License v3.0
20 stars 8 forks source link

IPv6 check #331

Closed vrragosta closed 1 month ago

vrragosta commented 1 month ago

Checks the kernel flags to see if IPv6 was explicitly disabled.

jackchallen commented 1 month ago

Immediate reaction is that you're checking the setting (has an explicit option been supplied?) rather than the effect (does IPv6 work?)

Ideally you test the effect rather than specific settings, because what actually matters is whether a process can bind to an IPv6 address, rather than a specific kernel option has been set. There are a couple of different ways of disabling IPv6 I think...

vrragosta commented 1 month ago

Immediate reaction is that you're checking the setting (has an explicit option been supplied?) rather than the effect (does IPv6 work?)

Ideally you test the effect rather than specific settings, because what actually matters is whether a process can bind to an IPv6 address, rather than a specific kernel option has been set. There are a couple of different ways of disabling IPv6 I think...

Addressed in latest commit.