search

weka511 / bioinformatics

Code inspired by Bioinformatics Algorithms: an Active Learning Approach.
GNU General Public License v3.0
115 stars 35 forks source link

The logic of SmallParsimony isn't clear #138

Closed weka511 closed 4 months ago

weka511 commented 1 year ago

It would be helpful to separate tree traversal from the calculation of the score

weka511 commented 1 year ago

I observed that SmallParsimony gets a different answer on Rosalind dataset 6 (12124 against an expected 12232). I have rewritten as NewSmallParsimony, to use a topological sort and numpy array. Agrees with dataset 1, but not 6.

weka511 commented 1 year ago

I still need to simplify backtracking

weka511 commented 4 months ago

Not a real problem