search

wekan / ldap

LDAP support for Wekan code has been moved to https://github.com/wekan/wekan/tree/master/packages/wekan-ldap , issues to https://github.com/wekan/wekan/issues , and if PRs are needed please add them instead to https://github.com/wekan/wekan/pulls
https://github.com/wekan/wekan/tree/master/packages/wekan-ldap
MIT License
12 stars 10 forks source link

Improving LDAP-Setting-Docs required? #77

Closed daMihe closed 4 years ago

daMihe commented 4 years ago

Currently, the examples are a bit mixed up (maybe some parameters have been renamed) and some doc-strings are missing. However, it was hard for me to set wekan-ldap-settings correctly as description was missing partly or not fully clear. I would share what i've learned in form of some docstrings. Where is the right place for that?

xet7 commented 4 years ago

@daMihe

You can add pull request to change these files:

Also, if you have any additional improvements to wiki page https://github.com/wekan/wekan/wiki/LDAP you can add them as comments to this issue. I added a link to this issue at top of that wiki page.

daMihe commented 4 years ago

Wekan seems to make the search as the user currently logged in, even if a separate user is used for searching users. This results in the requirement that every authenticated user has to have at least the right to search the ldap tree and to read the wekan-relevant groups.

This is verified using OpenLDAP allowing search to all authenticated users in whole tree and read for corresponding groups.

daMihe commented 4 years ago

Thank you for the fast process of reviewing and merging!

xet7 commented 4 years ago

From @daMihe

Wekan seems to make the search as the user currently logged in, even if a separate user is used for searching users. This results in the requirement that every authenticated user has to have at least the right to search the ldap tree and to read the wekan-relevant groups.

This is verified using OpenLDAP allowing search to all authenticated users in whole tree and read for corresponding groups.

If that is incorrect behaviour, you could look at LDAP code https://github.com/wekan/wekan/tree/master/packages/wekan-ldap about can you fix that. I know very little about how LDAP works, or should work.

daMihe commented 4 years ago

Hm - let's say the behavior is a bit... strange. If you know it, it's not so hard to work around. However i'll take a look whether i can do a simple fix these days.