search

weknowinc / react-bubble-chart-d3

React Bubble Chart using D3
MIT License
57 stars 57 forks source link

Bubbles Cut Off Regardless of Width #18

Closed witang closed 5 years ago

witang commented 5 years ago

Hi, I'm starting off by creating a pretty basic bubble chart with just two bubbles, each of them with some variable value.

However, I'm finding that no matter what values I put in and that no matter how large I make the "width" prop, the bubbles are still getting cut off:

screen shot 2018-12-04 at 7 38 41 am

Do you have any suggestions as to how to resolve this? Am I missing an additional CSS import?

Thanks.

jmsv23 commented 5 years ago

you can play with this values graph= { zoom: 1.1, offsetX: -0.05, offsetY: -0.01, } in the configuration of the graph to zoom in and zoom out the graph and the offset (x, y) that works for your particular case.

witang commented 5 years ago

Ah great. Thanks @jmsv23! So am I correct in assuming that the example props showing in the documentation are the "defaults"? That is, if I don't provide a graph config, it will automatically default to: graph = { zoom: 1.1, offsetX: -0.05, offsetY: -0.01, }?

jmsv23 commented 5 years ago

Yes Thats correct

PotLid commented 5 years ago

26

Fixed issue by allowing optionally using 'overflow' style attribute for this.svg. You can pass overflow prop (bool value) to BubbleChart component. If someone see this comments, please close the issues.