search

welaika / photocopier

FTP & SSH file copier
MIT License
17 stars 15 forks source link

sshpass is not working #2

Closed Arkham closed 11 years ago

Arkham commented 11 years ago

As found here, https://github.com/welaika/wordmove/issues/25

There is something wrong in this piece of code:

https://github.com/stefanoverna/photocopier/blob/master/lib/photocopier/ssh.rb#L72

Aside from mixing gateway and non-gateway options, we shouldn't rely on options[:sshpass], because if a user doesn't supply a sshpass field, this method will default to nil, thus disabling sshpass.

stefanoverna commented 11 years ago

@Arkham do you have time to propose a patch?

Arkham commented 11 years ago

This should be fixed.