welaika / wordmove

Multi-stage command line deploy/mirroring and task runner for Wordpress
https://wptools.it/wordmove
MIT License
1.87k stars 167 forks source link

// Silence is golden on wp-content #163

Closed luisbraga closed 7 years ago

luisbraga commented 9 years ago

Shouldn't wp-content folder have this index.php file on push? Also I've seen some plugins using wp-content for storing files. Should this also be taken into account?

alessandro-fazzi commented 9 years ago
  1. It should if it exists; otherwise it will delete it remotely
  2. We've encountered such plugins sometimes (wp-super-cache?); personally I disagree with the approach; anyway you should take it into account. Perhaps excluding the transfer of those file within Movefile

Feel free to reopen/continue the discussion as you need.

Cheers

luisbraga commented 9 years ago

Thank you,

  1. The file exists but it's not being uploaded on push. Same applies for other files created for testing.
  2. Same for existing folders other than the default wordpress install. They don't get uploaded.

This is my exclude config

exclude:

What could be wrong?

alessandro-fazzi commented 9 years ago

I'll do a fast check into the code to give you a more precise answer.

luisbraga commented 9 years ago

Just noticed in the log that "wordmove push --all" adds wp-content/* to the exclude list

▬▬ ✓ Pushing wordpress core ▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬▬ remote | putdirectory: /local/path/ /remote/path/ .git/ .gitignore .sass-cache/ bin/ tmp/* Gemfile* Movefile wp-config.php wp-content/.sql .DS_Store nodemodules/ bower_components/* wp-content/*

Is this expected when pushing all ?

alessandro-fazzi commented 9 years ago

We are discussing a similar thing in #214 @luisbraga

If you're interested your contribute should be helpful