welaika / wordmove

Multi-stage command line deploy/mirroring and task runner for Wordpress
https://wptools.it/wordmove
MIT License
1.87k stars 165 forks source link

Slash character in FTP username or password #320

Open simonschllng opened 8 years ago

simonschllng commented 8 years ago

When the ftp password contains a forward slash, all wordmove commands fail with "Name or service unknown". This is because lftp interprets the password as a path.

To fix this, the lftp call has to be rewritten. Current version:

lftp -c 'set ftp:list-options -a; open ftp://[user]:[pass]@[host]; ...'

Slash-save version:

lftp -c 'set ftp:list-options -a; open --user [user] --password [pass] ftp://[host]; ...'

Compare lftp manpage:

            --user user       use the user for authentication
            --password pass   use the password for authentication
alessandro-fazzi commented 8 years ago

Good catch @simonschllng ! 👍

Thanks to the time spent searching and reporting the solution too.

I've opened an issue for the gem of competence.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.