welaika / wordmove

Multi-stage command line deploy/mirroring and task runner for Wordpress
https://wptools.it/wordmove
MIT License
1.87k stars 167 forks source link

--simulate option does not work for push #480

Closed akishin closed 6 years ago

akishin commented 6 years ago

In push case, it seems that the --simulate option does not work because the options key becomes a String.

pull https://github.com/welaika/wordmove/blob/master/lib/wordmove/cli.rb#L68

deployer = Wordmove::Deployer::Base.deployer_for(options.deep_symbolize_keys)

push https://github.com/welaika/wordmove/blob/master/lib/wordmove/cli.rb#L92

deployer = Wordmove::Deployer::Base.deployer_for(options)

Is not the deep_symbolize_keys necessary also for push method?

alessandro-fazzi commented 6 years ago

Hello @akishin ,

not only you are totally right, but we have already a fix in 9541d8ff59bddc7e391e60c6b9a237f2d2c9906c

The branch should be merged and thus released really soon.

Thank you very much

alessandro-fazzi commented 6 years ago

@akishin https://github.com/welaika/wordmove/releases/tag/v3.1.2 is out with the fix :)

Thanks again