search

welaika / wordmove

Multi-stage command line deploy/mirroring and task runner for Wordpress
https://wptools.it/wordmove
MIT License
1.87k stars 167 forks source link

Change to call URI.open and File.open directly #584

Closed akiko-pusu closed 4 years ago

akiko-pusu commented 4 years ago

Hi, I've created a pull request related to #554.

Since Rubocop documentation was updated that I changed to call URI.open and File.open directly to prevent rubocop Security/Open.

Related issues:

Also, in Ruby2.7, Kernel#open finally became deprecated.

Hope this will be helpful to you.

NOTE: This pull request has no test code. If you need, I think it is necessary to cut out the function into smaller units and provide it in the form of unit tests.

alessandro-fazzi commented 4 years ago

Thank you very much for your work. This is helpful for sure :)

And don't worry about testing: you have not added new functioinalities and that piece of code is untestable and unreadable ^^" I'm working on a major refactor.

Thanks againt for contributing to the software!

akiko-pusu commented 4 years ago

Hi, @pioneerskies. Thank you so much for my tiny PR.

And I hope you’re all doing ok & staying safe.

alessandro-fazzi commented 4 years ago

Hey @akiko-pusu me and my colleagues are all located in North Italy, so we've been isolated at home for three weeks and conuting. But we're all healthy and working full time remotely.

Hope you're well too. Best wishes.