Interactors - Githubissues

welaika / wordmove

Multi-stage command line deploy/mirroring and task runner for Wordpress

https://wptools.it/wordmove

MIT License

1.87k stars 165 forks source link

Interactors #587

Closed alessandro-fazzi closed 2 years ago

alessandro-fazzi commented 4 years ago

All the refactors to open the road to a heavy use of interactor pattern inside the deployer (SSH and FTP)

The PR has at least these goals:

transform big pieces of procedural code into more structured, readable and functional code
remove - possibly - all the metaprogrammation
introduce developer documentation; the format has to be decided

This PR is actually this feature:

You may also use .env.{environmentname}, but this is discouraged.

due to technical problems during the refactor

This PR is behind master, so a couple of new features will need to be ported into the refactored codebase manually

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

alessandro-fazzi commented 4 years ago

Work note:

actions should not raise, but should fail the context with a message or at least the context should be failed before to raise

alessandro-fazzi commented 4 years ago

ATM we explicitly declare as Not Implemented the following features:

default (old) database adapter. I'm planning to removing it even if a serious approach would be a previous deprecation. The chance of this huge refactor is too big to not force the switch to a mandatory dependency on wp-cli.
FTP protocol. This will be implemented after the beta testing.

alessandro-fazzi commented 4 years ago

Code from #584 has been cherry picked

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.