welch-lab / liger

R package for integrating and analyzing multiple single-cell datasets
GNU General Public License v3.0
389 stars 78 forks source link

selectGenes No genes were selected #258

Closed scarlettcanny0629 closed 7 months ago

scarlettcanny0629 commented 2 years ago

Hi,

The selectGenes function is always reporting No genes were selected; lower var.thresh values or choose 'union' for combine parameter even with var.thresh= 0 threshold and union for combine parameter.

And the confusing thing is that when I set do.plot =T I can see that there are thousands of genes being selected.

I am wondering the issue causing this problem, thanks selectgenes !

mvfki commented 7 months ago

We have updated rliger quite a lot in new version 2.0. There are fixes happening in selectGenes(). I'm closing this Issue for now because it corresponds to a pretty old version. Please feel free to reopen it if you try the new rliger and still encounter this issue.