welch / tdigest

tdigest: javascript implementation of Dunning's T-Digest for streaming quantile approximation
MIT License
69 stars 11 forks source link

Migrate red black tree from bintrees to js-sdsl #12

Open ZLY201 opened 2 years ago

ZLY201 commented 2 years ago

Hey! I'm the developer of Js-sdsl. Official website: https://js-sdsl.github.io/

Now, we published the version 4.1.4.

I see you are using bintrees.

In benchmark, we have confirmed that Js-sdsl is several times faster than bintrees.

I've submitted a PR to eslint and has been accepted.

See https://github.com/eslint/eslint/issues/16255 and https://github.com/eslint/eslint/pull/16267.

I am willing to submit a pull request for this change.

Looking forward to your reply! :D

SiarheiFedartsou commented 1 month ago

Hey @welch What do you think? I could try to create a PR for that (but may be @ZLY201 wants as well...)

welch commented 1 month ago

I'll have a look! Thanks, --W

On Fri, Sep 27, 2024, 2:38 PM Siarhei Fedartsou @.***> wrote:

Hey @welch https://github.com/welch What do you think? I could try to create a PR for that (but may be @ZLY201 https://github.com/ZLY201 wants as well...)

— Reply to this email directly, view it on GitHub https://github.com/welch/tdigest/issues/12#issuecomment-2378976469, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALNQ544DANS24IAZQGJPN3ZYUYQRAVCNFSM6AAAAABO64KKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZYHE3TMNBWHE . You are receiving this because you were mentioned.Message ID: @.***>