Closed TApplencourt closed 6 years ago
Thanks for taking the time to author a potential change to the library's code.
While this refactoring could be an elegant change to the existing logic, it looks like you are not actually writing to the self._results
list. I believe that your change would also need to enumerate over the _input_combos
iterator, in order to keep track of the current position within the self._results
list.
If you fix what I pointed out and your changes pass all of the CI tests (including the pep8 linting), I would be happy to accept your PR.
Hi,
I don't know if this pull request will be off any interest for you, but I retractor the
fill
function oftry_table
. It should be marginally quicker and arguably more maintainable.Regards,
PS : Sadly, I didn't test my modification, so take it with a grain of salt