search

weld-project / weld

High-performance runtime for data analytics applications
https://www.weld.rs
BSD 3-Clause "New" or "Revised" License
2.99k stars 259 forks source link

Fix some memory leaks #429

Closed Max-Meldrum closed 5 years ago

Max-Meldrum commented 5 years ago

Thanks for the comments. I've updated the code. I have left some TODOs where the calls are allocating memory using C++ new, although it is possible to libc::free them, it is usually not recommended.

leaks

Max-Meldrum commented 5 years ago

Getting zero leaks now. Let me know if there is anything that should be modified

Cheers

sppalkia commented 5 years ago

Looks great, thanks so much for fixing these!