search

weld-project / weld

High-performance runtime for data analytics applications
https://www.weld.rs
BSD 3-Clause "New" or "Revised" License
2.99k stars 259 forks source link

Add python3 support for grizzly #430

Closed williamma12 closed 5 years ago

williamma12 commented 5 years ago

What do these changes do

Adds python3 support for grizzly

sppalkia commented 5 years ago

Hey Will,

This looks pretty good, I don't have any specific comments. Just to clarify, this will break things with Python2, right? It may be worth adding a comment about this in the README since it will likely break all the existing benchmarks and examples.

In fact, for that reason, it may make more sense to keep this as a separate branch altogether, where the Weld compiler part is kept in sync with llvm-st and the Python3 dev happens there. We can merge it back in after updating the benchmarks etc.

sppalkia commented 5 years ago

The sort/groupBy may have broken due to an earlier change (we haven't been testing Grizzly as actively as the main compiler) -- I can post a patch for that in a different PR. Thanks for pointing it out!

sppalkia commented 5 years ago

From @williamma12:

before we can merge python3 branch into llvm-st, we’ll have to fix the circular dependencies in grizzly and fix the fact that python3 wont find SUPPORTED_DTYPES after doing from weldnumpy import *