search

weld-project / weld

High-performance runtime for data analytics applications
https://www.weld.rs
BSD 3-Clause "New" or "Revised" License
2.99k stars 259 forks source link

Weld Serialize/Deserialize #446

Closed Max-Meldrum closed 5 years ago

Max-Meldrum commented 5 years ago

I am using Weld's serialize(data) and deserialize[T](data) in a project. As most other libraries handle bytes as Vec<u8>, I am currently having to cast between i8/u8 while going from Weld to other libraries (e.g., RocksDB, Protobuf) and vice versa. Is there a motivation behind the choice of Vec<i8>?

I could look into creating a PR for this. Or if it would be breaking other projects relying on the current implementation, I could work on a fork instead.

Cheers

sppalkia commented 5 years ago

Hi Max,

You can submit a PR for this if you’d like — I think u8 makes more sense too and I don’t think it’ll break anything else.

Shoumik

On Fri, May 3, 2019 at 4:56 AM Max Meldrum notifications@github.com wrote:

I am using Weld's serialize(data) and deserializeT in a project. As most other libraries handle bytes as Vec, I am currently having to cast between i8/u8 while going from Weld to other libraries (e.g., RocksDB, Protobuf) and vice versa. Is there a motivation behind the choice of Vec?

I could look into creating a PR for this. Or if it would be breaking other projects relying on the current implementation, I could work on a fork instead.

Cheers

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/weld-project/weld/issues/446, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKMEY3MVHD4LFGXD353JILPTP44PANCNFSM4HKSHVOA .

-- Shoumik