Closed boegel closed 4 years ago
Hmm, I'm not able to reproduce this, what do you see when you run llvm-config --version
?
Good points re: README, I will fix those.
As expected, 6.0.1 (part of the Clang installation)
$ llvm-config --version
6.0.1
$ which llvm-config
/software/Clang/6.0.1-GCC-7.3.0-2.30/bin/llvm-config
Hmm okay, let me look into this; I suspect it’s because building from source enables some debug assertions or something, so that will need to be fixed.
In the meanwhile, you can try using the LLVM distribution available on brew (or follow the instructions on the README), that should work.
On Sun, Sep 22, 2019 at 1:14 PM Kenneth Hoste notifications@github.com wrote:
As expected, 6.0.1 (part of the Clang installation)
$ llvm-config --version 6.0.1 $ which llvm-config /software/Clang/6.0.1-GCC-7.3.0-2.30/bin/llvm-config
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/weld-project/weld/issues/473?email_source=notifications&email_token=AAKMEY2L3LRF6T2L53XPBJTQK7G3RA5CNFSM4IZDDQXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JOIZA#issuecomment-533914724, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKMEY2YFR74N6XAFBX2QBDQK7G3RANCNFSM4IZDDQXA .
-- Shoumik
Clang/LLVM built with this build system typically has -DLLVM_ENABLE_ASSERTIONS=ON
.
I've tested four different builds of the toolchain:
The distro's compiler and the 6.0.1 without assertions pass the test suite, the two builds with assertions bail out in the same manner that @boegel's did.
Okay, I built it from source and was able to reproduce this. Will post a patch shortly.
I tried installing Weld 0.3.1 on top of Rust 1.37.0 and Clang 6.0.1 (both installed from source using GCC 7.3), but ran into test failures. I ran into the same failure when using Rust 1.37.0 and Clang 8.0.1 & 9.0.0 where both were built from source using GCC 8.2.
Executed commands with output under the
Details
dropdown:Output for failing test:
Full output of
cargo test --release
:Is this a known issue, or am I overlooking something?
Side notes:
README
mentions that LLVM is required, but you actually need Clang, sinceclang++
is used during the build;README
also mentions "To build Weld, you need ... and LLVM 6.0 or newer
". This lead me to believe that LLVM 7/8/9 would also work (but #468 says 6.0.x is required).