search

weld-project / weld

High-performance runtime for data analytics applications
https://www.weld.rs
BSD 3-Clause "New" or "Revised" License
2.99k stars 259 forks source link

Python 3 support #474

Open rth opened 4 years ago

rth commented 4 years ago

Thanks for this library!

Just a reminder that most major scientific Python packages have dropped Python 2 support now, so only supporting Python 2 is quite problematic.

Related to https://github.com/weld-project/weld/issues/110

There was a WIP attempt in https://github.com/weld-project/weld/pull/132 that didn't receive much interest.

Is the Python 3 migration something you expect to happen? Any help needed there?

sppalkia commented 4 years ago

This is being worked on! Expect to see it in a day or two, it’s just about complete — we are also dropping support for Python 2 and switching completely over to Python 3.

On Sun, Sep 22, 2019 at 9:29 AM Roman Yurchak notifications@github.com wrote:

Thanks for this library!

Just a reminder that most major scientific Python packages have dropped Python 2 support now, so only supporting Python 2 is quite problematic.

Related to #110 https://github.com/weld-project/weld/issues/110

There was a WIP attempt in #132 https://github.com/weld-project/weld/pull/132 that didn't receive much interest.

Is the Python 3 migration something you expect to happen? Any help needed there?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/weld-project/weld/issues/474?email_source=notifications&email_token=AAKMEY7B7J2XZIWCDYYOPETQK6MQBA5CNFSM4IZDPU5KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HM4S5UQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKMEY25NKXYYHIP2DJ4D2LQK6MQBANCNFSM4IZDPU5A .

-- Shoumik

rth commented 4 years ago

Great to hear that!

On a related subject, are there any plans to use PyO3 or something similar for the Python wrapper to avoid manually setting WELD_HOME env variable at build time?

dazzag24 commented 4 years ago

I'd love to see Python3 support. Happy to give it a try if you want help testing.

sppalkia commented 4 years ago

That would great! Expect a PR in the coming days here. @rth yes, we're eliminating the environment variables required to build it in this patch.

ashermancinelli commented 4 years ago

Could we get an update on this? I still see all the docs use python3 atm. I would be happy to update the docs once this issue is resolved.