Use of deprecated lib feature `std::sync::ONCE_INIT`

AngleNet commented 5 years ago

Summary: Use of deprecated lib feature std::sync::ONCE_INIT Environment: Ubuntu 18.04, Rust 1.38.0 Reproduce: cargo build --release Output:

warning: use of deprecated item 'std::sync::ONCE_INIT': the `new` function is now preferred
  --> weld/src/codegen/llvm2/mod.rs:74:1
    |
74| / lazy_static! {
75| |     /// Name of the run handle struct in generated code.
76| |     static ref RUN_HANDLE_NAME: CString = CString::new("RunHandle").unwrap();
77| | }
    | |_^
    |
   = note: `#[warn(deprecated)]` on by default
   = note: this warning originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)

AngleNet commented 5 years ago

Need a fix?

sppalkia commented 5 years ago

Sure! I believe most of these are from lazy_static, so bumping to a newer version of it in Cargo.toml should fix that. There’s also one or two places it’s used in the codebase as well.

Thanks!

On Fri, Oct 4, 2019 at 8:38 AM AngleNet notifications@github.com wrote:

Need a fix?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/weld-project/weld/issues/489?email_source=notifications&email_token=AAKMEY5ABI2SSFTNHQ54DTDQM2XRXA5CNFSM4I5KSIM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAKG4OI#issuecomment-538209849, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKMEY33CSIEAXKRS6AICA3QM2XRXANCNFSM4I5KSIMQ .

-- Shoumik

AngleNet commented 5 years ago

Yes，There are bunch of warnings. I will open a PR to fix that.

AngleNet commented 5 years ago

Fixed in #491 . Closing this.

weld-project / weld

Use of deprecated lib feature `std::sync::ONCE_INIT` #489