search

weld-project / weld

High-performance runtime for data analytics applications
https://www.weld.rs
BSD 3-Clause "New" or "Revised" License
2.99k stars 256 forks source link

Remove deprecated feature of std::sync::ONCE_INIT #491

Closed AngleNet closed 5 years ago

AngleNet commented 5 years ago

Bump lazy_static to latest release 1.4.0 and replace ONCE_INIT with Once::new() in the code base.

AngleNet commented 5 years ago

Still has warnings for deprecated std::mem::uninitilized(). Working in progress. Plan to fix it in same PR. Is that OK?

sppalkia commented 5 years ago

Yes, that’s fine! Thanks for the patch.

On Fri, Oct 4, 2019 at 9:23 PM AngleNet notifications@github.com wrote:

Still has warnings for deprecated std::mem::uninitilized(). Working in progress. Plan to fix it in same PR. Is that OK?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/weld-project/weld/pull/491?email_source=notifications&email_token=AAKMEYZLRUBR3GBFRSSWP2DQM5RG3A5CNFSM4I5ROXQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAMDAOY#issuecomment-538456123, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKMEYYFGMV47GRPGQG25NTQM5RG3ANCNFSM4I5ROXQQ .

-- Shoumik

AngleNet commented 5 years ago

Fixed mem::uninitialized. @sppalkia Help review this. Thank you ~~~

sppalkia commented 5 years ago

Looks great, thanks for the submitting it!