mkksiso: option --replace to replace arbitrary text in boot config.

weldr / lorax

Tools for creating images, including the Anaconda boot.iso, live disk images, iso's, and filesystem images.

GNU General Public License v2.0

294 stars 157 forks source link

mkksiso: option --replace to replace arbitrary text in boot config. #1402

Closed sstark closed 3 months ago

sstark commented 3 months ago

It is a generalized version of the code that replaces the volume ID.
Test adjusted accordingly because signature changed slightly.
This can be used to augment/change the user visible boot menu to add more information about the kickstart installation that is going to happen.
Implemented for grub and isolinux, not s390 (don't know how to test).

bcl commented 3 months ago

Thanks, this looks pretty good, but please also update it for S390 and don't worry about testing -- the volid change should be enough and the signature for the functions needs to be consistent.

sstark commented 3 months ago

I added a commit on top for that, let me know if you would rather have that squashed into one.