search

welfare-state-analytics / riksdagen-corpus

Swedish parliamentary proceedings - Riksdagens protokoll 1867-today
Other
26 stars 5 forks source link

Remove R package #431

Closed MansMeg closed 8 months ago

MansMeg commented 8 months ago

Hi!

I have moved the R package to a separate repository and added some information in the README.

I also moved the SWERIK presentation to supplementary materials.

MansMeg commented 8 months ago

It seems like the unit test checks that the presentation ppt is part of the root?

BobBorges commented 8 months ago

It seems like the unit test checks that the presentation ppt is part of the root?

I think it fails because the parentheses are not escaped in (eng) image

BobBorges commented 8 months ago

I pushed commit that might fix the problem, but probably we should revert the workflow file after, since the change makes it less efficient (calls test/unchanged.py once on each file instead of once on all files).

This is a good lesson on not putting spaces and other spooky stuff in file paths.

BobBorges commented 8 months ago

Nah, it still fails. @MansMeg I don't know how proper it would be in this case, but we could not run this unit test this time around, or if the unit test failing doesn't block the merge, just merge anyway. I either of these options would cause an issue with this file until the delete is merged into main.

@ninpnin do you have any idea how to correctly handle this? Changing the name will cause the unit test to fail in the same way.

ninpnin commented 8 months ago

I think the "don't ever make changes to these files" requirement is outdated.

I.e. we could remove that test.

BobBorges commented 8 months ago

The unchanged.py unit test didn't actually check anything, only that the directory (not it's content) input/curation/ isn't listed in the changed/deleted files. Removed from the workflow & should fix the problem here.