search

welfare-state-analytics / riksdagen-corpus

Swedish parliamentary proceedings - Riksdagens protokoll 1867-today
Other
26 stars 5 forks source link

Change name of id variables #475

Closed MansMeg closed 4 months ago

MansMeg commented 5 months ago

Our person_id is now called swerik_id. This is problematic for two reasons.

  1. It doesn't say what the id is actually about (persons)
  2. swerik is probably a name we want to avoid in the database since the data will survive longer than the project

I suggest we change swerik_id to person_id

I think ideally this is fixed before 1.0.

fredrik1984 commented 5 months ago

Aha, I thought we already had decided about not having "swerik" in the id name, for the reason you mentioned. I also think "person_id" is a good choice since we will have other persons who are not MPs in our database as well (some ministers, the monarch, etc).

MansMeg commented 5 months ago

Yes, I thought so to, but I saw it some of the files so I opened an issue.

BobBorges commented 5 months ago

Ok, sorry if I missed the point somewhere. Can change to person_id.

MansMeg commented 5 months ago

No big problem. Its just that column name changes will not be back compatible. I.e. after 1.0, we will need to bump the major version. =)

ninpnin commented 5 months ago

Also, the thing will remain to be called SWERIK ID on Wikidata

MansMeg commented 5 months ago

Ok. We should probably fix that as well, long term.

ninpnin commented 5 months ago

? what should it be called there, then?

BobBorges commented 5 months ago

I'm not sure if it should be changed there -- the IDs will still resolve to the Swerik web page after the project so long as no one deletes the github organization. I think we ought to leave it swerik ID until/unless some other organization takes over administration of these IDs.

MansMeg commented 5 months ago

Ok. Sounds fair. Then we only need to do this in our corpus.

BobBorges commented 4 months ago

Done in the swerik-project repos.