search

welford-media / craft3-barclays-epdq

Other
0 stars 1 forks source link

Feature Request: Provide SHA algorithm selection #2

Closed peteeveleigh closed 3 years ago

peteeveleigh commented 3 years ago

ePDQ can use either sha1, sha256, or sha512 for its encryption algorithm.

The plugin currently fixes that selection as sha1 - the least secure of the three options. And also provides no indication of doing so. This means that submissions fail if the ePDQ installation is set to use anything other than sha1.

Could you provide a setting to allow for selection of any of the 3 sha methods and adapt the calculate sha method in the plugin to use the appropriate one?

timjai commented 3 years ago

We've had the same issue so I've created a pull request for this.

peteeveleigh commented 3 years ago

@timjai fantastic. I already modified the plugin once but forgot I'd done it and overwrote my change with a reinstallation. Was trying to make the time to do it again.