welford / twexe

Tiddlywiki widget to run batch/exes on a local machine. Intended for hta.
8 stars 1 forks source link

transcludsion fails for multiple tiddlers #1

Closed shadowforce62 closed 1 year ago

shadowforce62 commented 1 year ago

If more then one tiddler is transcluded then it sends the actual transclude Text to the console

Example

{{Hello Tiddler}} (Echo Hello World!) {{Goodbye Tiddler}} (Echo Goodbye World!)

Tiddler running


@echo off {{Hello Tiddler}} {{Goodbye Tiddler}} Pause

Result: Hello World! {{Goodbye Tiddler}} is not recognized as an internal or external command Press any key to continue.

welford commented 1 year ago

Will take a look, should be a quick fix.

On Thu, 9 Feb 2023, 23:29 shadowforce62, @.***> wrote:

If more then one tiddler is transcluded then it sends the actual transclude Text to the console

Example

{{Hello Tiddler}} (Echo Hello World!) {{Goodbye Tiddler}} (Echo Goodbye World!)

Tiddler running

@echo https://github.com/echo off {{Hello Tiddler}} {{Goodbye Tiddler}} Pause

Result: Hello World! {{Goodbye Tiddler}} is not recognized as an internal or external command Press any key to continue.

— Reply to this email directly, view it on GitHub https://github.com/welford/twexe/issues/1, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDAWP477SB7TNOU5A2KZJDWWV4VJANCNFSM6AAAAAAUXEZNS4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

welford commented 1 year ago

maybe https://github.com/welford/twexe/commit/b0147b08baa8dbff5592b3b923d89313f77769c7 is a fix, i haven't reproduced the issue locally - your setup works for me. but this should fix a recursive pattern. Are you able to try this commit? I'll build it into my samples maybe tomorrow.

shadowforce62 commented 1 year ago

Now it fails after 3x commands instead of 2. better but not fixed i only imported twexe.js to the HTA file not all .tid's im currently running TW5.2.5 Screenshot 2023-02-25 224653

shadowforce62 commented 1 year ago

if it helps i can send the TW file im using as an HTA, im also going to try downloading the demo one and updating it to see if its just a tw5.2.5 issue. i have a few other plugins that may/maynot be causing conflicts, im also storing all my "Code Snippets" as plain/txt

shadowforce62 commented 1 year ago

I think this may help, i've updated twexe.js in the demo page you have online and added 5 transclusions, i've notice a pattern because the first 3 worked instead of the first 2, adding null values ({{nul}}) that points to just :: i was able to get it to read all five lines correctly the more nuls added the more it trancludes. the tiddler looks like this:

created: 20230226035843256
modified: 20230226040609323
tags: $:/tags/twexe
title: Debug
type: text/plain

{{Debug_1}}
pause
{{Debug_2}}
pause
{{Debug_3}}
pause
{{Debug_4}}
pause
{{Debug_5}}
pause
{{nul}}
{{nul}}
{{nul}}
{{nul}}
{{nul}}
{{nul}}
pause

Screenshot 2023-02-25 230717

Side Note: Im using windows 11 and TW 2.5.3 (The Demo Version @ http://welford.github.io/twexe/twexe.plugin.html) with an updated twexe.js file only

Temporary Fix For anyone else with this issue:

Create a new Tiddler named "Nul" Add :: to the tiddler body Spam {{Nul}} at the bottom of the script if you use to many it will just add a comment line that will be ignored tested up to five transclusions. cant seem to tranclude more than 5/6

welford commented 1 year ago

can send the TW file im using as an HTA, im also going to try downloading the demo one and updating it to see if its just a tw5.2.5 issue. i have a few other plugins that

plain text is fine, could you please share a html version of your example? Renaming the hta is fine. thanks!

shadowforce62 commented 1 year ago

inside the zip is the .htm file. look for the tiddler named debug in recent. in my machine the script will execute properly so long as {{Nul}} is appended to the end like so, Delete the nul values and you should see it fail to run transcluded tiddlers twexe.plugin.zip

shadowrevenant commented 1 year ago

(Second account, I'm shadowforce62) Would something kinda like

<a name=<<currentTiddler>>>
<$transclude tiddler="$:/core/ui/ViewTemplate"/>
</a>

Solve this issue? Shot in the dark?

shadowrevenant commented 1 year ago

Just without the UI part?

welford commented 1 year ago

sorry for the delay, but https://github.com/welford/twexe/commit/cfc4d3c197fcec3eb44530f12cc7ec1b3f88f764 should be a fix for this. Thanks for the sample.

shadowforce62 commented 1 year ago

Awesome, looks like it works just fine I'm piling translations and they seem to work, I can't tell if I'm jumbling my code or not but I'm no longer getting '{{Tiddler}}' not recognized errors. i think its safe to mark this one fixed

welford commented 1 year ago

thanks i have updated my public wikis with the new plugins.