search

weliem / bluez_inc

A C library for Bluez (BLE) that hides all DBus communication. It doesn't get easier than this. This library can also be used in C++.
MIT License
84 stars 19 forks source link

Prototypes and casts #52

Closed abqjln closed 2 weeks ago

abqjln commented 2 weeks ago

Added prototypes and casting to silence gcc with -Wall -Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wconversion so I can focus on my mistakes.

weliem commented 2 weeks ago

Thank you for submitting this PR. However, there is a lot of stuff in this PR and I would prefer to take smaller PRs that tackle 1 issue at a time. For example, this library is already built with "-Wall -Werror -Wextra -Wno-unused-function -Wno-unused-parameter". You seem to be interested in "Wstrict-prototypes -Wmissing-prototypes -Wshadow -Wconversion" but I don't want to loose the additional options I already had and would be removed by your PR.

Next to that you are moving code around that has nothing to do with silencing these options and you also highly modified the cmake files.

Can we break this up into several PRs? e.g.: PR1: Address "Wstrict-prototypes -Wmissing-prototypes" PR2: Address "-Wshadow -Wconversion" PR3....whatever is left?

abqjln commented 2 weeks ago

Absolutely will do. cmake changes were an error. Will start over. Thanks for bearing with my over-enthusiasm.