Adds support for ByteStrings in inside JSON

well-typed / cborg

Binary serialisation in the CBOR format

https://hackage.haskell.org/package/cborg

191 stars 86 forks source link

Adds support for ByteStrings in inside JSON #254

Closed yaitskov closed 1 year ago

yaitskov commented 3 years ago

I am implementing WebAuthn authentication. Chrome browser returns part of data encoded in CBOR and uses 58/59 bytes (fixed byte string with length up to 255/65535 bytes) to encode key.

I think exposing such type as a hex string in JSON is best option. Aeson.Array Number is much less efficient.

extra dependency on base16

yaitskov commented 3 years ago

@phadej

phadej commented 3 years ago

I don't understand why I'm pinged here.

yaitskov commented 3 years ago

I was looking for reviewers and found you among previous ones.

phadej commented 3 years ago

That's the way I ended up "maintaining" plenty of stuff :)

yaitskov commented 3 years ago

CI is green except on gch 7.8.4 because store package dropped 7.8.4 support

9883f44 - Remove configuration for building with ghc-7.8 (4 months ago) (Michael Sloan)

phadej commented 3 years ago

could store maintainers correct the metadata then: https://matrix.hackage.haskell.org/#/package/store, there shouldn't be red cells.

phadej commented 3 years ago

Please, let's not workaround others' bugs (which are easily fixable). There is no hurry.

yaitskov commented 3 years ago

PR CI is green, thanks to store team efforts. https://github.com/mgsloan/store/issues/157