search

well-typed / cborg

Binary serialisation in the CBOR format
https://hackage.haskell.org/package/cborg
191 stars 86 forks source link

Add support for bytestring 0.11 #256

Closed sjakobi closed 3 years ago

sjakobi commented 3 years ago

http://hackage.haskell.org/package/bytestring-0.11.0.0/changelog

Since cborg uses the internal PS constructor which is a bundled pattern synonym in bytestring >= 0.11, we stick to bytestring < 0.11 for GHC < 8.0 where bundled pattern synonyms aren't supported.

sjakobi commented 3 years ago

Until attoparsec (https://github.com/haskell/attoparsec/issues/174) and uuid-types (https://github.com/haskell-hvr/uuid/pull/54) have compatible releases, this can be tested with --allow-newer='uuid-types:bytestring,attoparsec:bytestring'.

sjakobi commented 3 years ago

Ping @bgamari, @thoughtpolice! :)

sjakobi commented 3 years ago

Thanks for the suggestion @dcoutts. I've much simplified the patch by disallowing bytestring >= 0.11 with GHC < 8.0.