well-typed / falsify

Other
36 stars 5 forks source link

Add to Stackage? #71

Closed theGhostJW closed 3 months ago

theGhostJW commented 7 months ago

Would be useful to have this package in stackage. Are there any plans to do so?

pgujjula commented 5 months ago

Bumping this, this would be really useful for me as well!

pgujjula commented 4 months ago

Unfortunately I'll have to stop using this library in my project since it's not on Stackage :/ I'd would love to switch back to it if it becomes available!

Bodigrim commented 4 months ago

Anyone can add anything to Stackage, it does not have to be a maintainer ;)

pgujjula commented 4 months ago

Oh true... if it doesn't get added I'll add it myself in two weeks

theGhostJW commented 4 months ago

https://github.com/commercialhaskell/stackage/blob/master/MAINTAINERS.md#adding-a-package

Adding a package

Anyone can add any package to Stackage but you should talk to the upstream maintainer before putting another person's package under your own name. It's generally better the actual package maintainer is also the Stackage maintainer, if that is not the case you should write the package maintainer a note first, eg by opening an upstream issue or sending them an email.

Seems quite strange that it is possible for anyone to put anyone else's package under their own name on Stackage. I think you would want a thumbs up from @edsko at the very least.

pgujjula commented 4 months ago

I think the idea isn't that you're taking credit for or control of the package, just that you're the point of contact for Stackage. It would be preferable for the author to add it to Stackage instead of me, so I'm giving them a good chunk of time to respond. @edsko if you want to add yourself, or don't want it added for some reason, please let me know :) And of course if you ever want the Stackage maintainership of falsify transferred to you at any time in the future I will do so.

edsko commented 4 months ago

Sorry, I'm just swamped with work, no time for much of anything :/ Yes, by all means, feel free to add it! Thank you :)

theGhostJW commented 4 months ago

Looks like you are set to go @pgujjula. Ping me here if you can't get it done and I'll pick it up in the next couple of weeks

pgujjula commented 4 months ago

@edsko Thanks! ghc-9.8 needs to be allowed before inclusion into Stackage, can you take a look at https://github.com/well-typed/falsify/pull/72?

edsko commented 4 months ago

72 is now merged :)

pgujjula commented 4 months ago

Thank you! Could you republish to Hackage @edsko?

edsko commented 4 months ago

Is it sufficient to make a Hackage revision? We've just relaxed some bounds right?

edsko commented 4 months ago

I've created the Hackage revision. Let me know if this is insufficient (but I will probably not see that until next week).

pgujjula commented 4 months ago

Oh yes, it should be sufficient to create a Hackage revision. Thanks, I'll update shortly.

pgujjula commented 4 months ago

Opened a PR to add falsify to Stackage here: https://github.com/commercialhaskell/stackage/pull/7427

pgujjula commented 3 months ago

falsify is now added to Stackage! 🙂

edsko commented 3 months ago

Very nice, thanks! :)