search

well-typed / ghc-events-analyze

BSD 3-Clause "New" or "Revised" License
67 stars 23 forks source link

Add support for GHC 7.10 #15

Closed WillSewell closed 9 years ago

WillSewell commented 9 years ago

Let me know if you have any feedback :)

edsko commented 9 years ago

Oh, wow, you even made it compatible with diagrams 1.2 and diagrams 1.3. Looks good. Merging with thanks! I noticed that it doesn't compile with 7.8 but I also noticed that this isn't the fault of this PR :) Will fix that separately.

edsko commented 9 years ago

@WillSewell Ok, fixed the compilation issues with 7.8 separately. Do you consider this in a good state for a new Hackage release?

WillSewell commented 9 years ago

Great! Yeah it was more fiddly to port over than I expected it to be.

Thanks for fixing the TH bounds. Is there a reason there was no explicit template-haskell bounds in ghc-events-analyze.cabal?

I consider it in a good state now then if it seems to be working on 7.8 and 7.10. I was using the 7.10 build yesterday with no issues.

edsko commented 9 years ago

Ok, released. Re TH bounds, I usually leave them unspecified as they are compiler dictated.

WillSewell commented 9 years ago

Thanks!

That makes sense.