search

well-typed / ghc-events-analyze

BSD 3-Clause "New" or "Revised" License
67 stars 23 forks source link

Fix tracking of threads across windows #20

Closed WillSewell closed 8 years ago

WillSewell commented 8 years ago

Finally fixed https://github.com/well-typed/ghc-events-analyze/issues/17. Went for the first solution I came up with in that issue.

The currently running threads are now stored in RunningThreads which is global state across windows in an analysis. When a window is entered, all running thrads are reported as started. and when a window is stopped, all running threads are reported as stopped for that window.

This does not support tracking of events that were started before a window, but stopped after a window is started. I'm not sure how valuable this would be.

edsko commented 8 years ago

I will try to look at this (and rebase it) soon, hopefully this week.

WillSewell commented 8 years ago

Thanks. I could try and rebase if you're pressed for time. Just let me know.

edsko commented 8 years ago

Ok, rebased and merged. Looks good! Thanks for doing that. Will release now.

edsko commented 8 years ago

Released version 0.2.3. Thanks once again! :)

edsko commented 8 years ago

Whoops, discovered I introduced a bug in the timeline rendering (#21). Released 0.2.4 :flushed:

WillSewell commented 8 years ago

Thanks! And no problem; it was about time!