search

well-typed / grapesy

Native Haskell gRPC client and server based on `http2`
Other
31 stars 4 forks source link

Add Snappy compression #87

Closed FinleyMcIlwaine closed 4 months ago

FinleyMcIlwaine commented 4 months ago

Resolves #56

FinleyMcIlwaine commented 4 months ago

I've re-enabled 8.10.7 support, and made a revision on hackage to support 8.10.7 in snappy-c, so we can test snappy on all versions. The only issue is that snappy-c requires bytestring >= 0.11, which is greater than the version bundled with 8.10.7. So the default haskell-ci behavior of adding constraint: pkg installed for each boot package pkg leads to resolution failures on 8.10.7. The best way I've found to address this is adding installed: -all to the haskell-ci configuration. Let me know how that looks to you!

edsko commented 4 months ago

The dependency on bytestring seems unproblematic. I've rebased this branch and have changed the snappy flag to be automatic and default to true; for full compliance, this seems the better default.