search

well-typed / optics

Optics as an abstract interface
375 stars 24 forks source link

optics-0.4 release #375

Closed phadej closed 3 years ago

phadej commented 3 years ago

I'm very eager to use indexed-traversable.

I haven't followed the LabelOptic changes, is the #365 only things left?

Does @adamgundry or @arybczak have some breaking changes in mind, which would be great to get in?

I think it would be great to have GHC-9.0 compatible release as soon as it is released, so that could be a (soft) deadline for optics-0.4.

arybczak commented 3 years ago

Apart from #365 I need to port a bit from https://github.com/ekmett/lens/pull/945. Other than that I think it's good to go.

adamgundry commented 3 years ago

Sorry, I haven't been keeping up because of "holidays", but I'm supportive of releasing optics-0.4 around the GHC-9.0 release if not before. I'll try to find an opportunity to properly review the recent changes in the next week or so. But I don't have anything that is urgent to land before a release.

phadej commented 3 years ago

GHC-9.0 is released.

arybczak commented 3 years ago

I suggest merging #399 and getting a release out.

adamgundry commented 3 years ago

Sounds good to me!

adamgundry commented 3 years ago

We don't have CI for GHC 9.0.1 yet (https://github.com/haskell-CI/haskell-ci/issues/474), but I've verified locally that the main packages build and pass tests.

Still lacking:

As far as I can see we need to:

I'm going to open a PR with some minor changelog fixes. Provisionally I'm planning to make a release early next week. Anything else we need to do first?

adamgundry commented 3 years ago
phadej commented 3 years ago

I tested some small developments, and at least optics-core package doesn't break anything unexpectedly there

adamgundry commented 3 years ago

I've made the release.

phadej commented 3 years ago

Hurray!