search

well-typed / optics

Optics as an abstract interface
376 stars 24 forks source link

Relax bounds of th-abstraction #482

Closed arybczak closed 1 year ago

arybczak commented 1 year ago

I added corresponding hackage revisions.

phadej commented 1 year ago

The CI wasn't actually built against th-abstraction-0.5

in dump install-plan step:

 - th-abstraction-0.4.5.0 (lib) (requires download & build)

To test locally one needs to allow-newer for bifunctors and th-abstraction: 

cabal build optics-th  --constraint='th-abstraction>=0.5' --allow-newer=generics-sop:th-abstraction --allow-newer=bifunctors:th-abstraction

@arybczak for the next time, please mention in the description of PR if you have tested locally when CI doesn't actually exercise a build plan.

arybczak commented 1 year ago

Right. FWIW I did test it by relaxing the bounds with cabal.project.local.