search

wellbia / redmine_microsoftteams

Microsoft Teams plugin for Redmine
MIT License
4 stars 4 forks source link

Project Custom Property: "Teams Channel" #13

Open vsc55 opened 1 month ago

vsc55 commented 1 month ago

Hi, On the configuration page it says this: The channel can be changed on a per-project basis by creating a project custom field named "Teams Channel" (without quotes). For public channels, this value should start with a #.

But when I have been creating the pr for multiple languages, I have not seen any reference to "teams channel" anywhere. Is this actually working, or did I miss something?

hgyoon-w commented 1 month ago

I think it was written incorrectly. If you set custom field named "Teams URL", it will be sent to that webhook.

vsc55 commented 1 month ago

Hi @hgyoon-w,

I think it is a remnant of the original "redmine-slack" source that does have a "Slack Channel". In this case I think this would be unnecessary.

vsc55 commented 1 month ago

@hgyoon-w It would also be good to review this: https://github.com/wellbia/redmine_microsoftteams/blob/b7fa1cf5151dff07cffc3ef26b66b671ade34bfe/lib/redmine_microsoftteams/listener.rb#L288

It can be overridden by this as it depends on the database engine it may not be case sensitive. cf = ProjectCustomField.where('LOWER(name) = ?', 'teams url').first

https://github.com/wellbia/redmine_microsoftteams/issues/6