search

wellcomecollection / alpha

Alpha version of a catalogue explorer for Wellcome Library (deprecated).
0 stars 0 forks source link

Change image URL template to use DLCS instead of Wellcome DDS #123

Closed tomcrane closed 8 years ago

tomcrane commented 8 years ago

This makes alpha use DLCS image API endpoints instead of Wellcome Library ones. I think this is the only change that needs to happen.

@frankieroberto @jennpb - is there a staging environment where this can be tested?

tomcrane commented 8 years ago

@jennpb - I guess we should just push this tomorrow.

jennpb commented 8 years ago

@tomcrane I'm free after 1PM. Can do it then?

tomcrane commented 8 years ago

@jennpb Should be fine and timely to do then,

jennpb commented 8 years ago

Hi @frankieroberto and @george08. We need to push this change so that alpha is no longer pointing to the now-defunct DDS but rather the DLCS. We can do it with a bit of guidance from you - are either of you able to advise? thx!

frankieroberto commented 8 years ago

@jennpb I've checked this locally, works fine. If you merge, it should auto-deploy within a few mins. (You can check by viewing URLs that the images embedded within the pages are served from).

When checking the live site, you might want to look at https://wellcomelibrary-alpha.herokuapp.com (as that by-passes the CDN caching-layer).

This might be a good page to test, as it has loads of thumbnails on it: http://wellcomelibrary-alpha.herokuapp.com/collections/aids or http://wellcomelibrary-alpha.herokuapp.com/b20086040

george08 commented 8 years ago

Let us know how you get on.

... George Oates Director gfns.uk

On 24 Aug 2016, at 23:08, Frankie Roberto notifications@github.com wrote:

@jennpb I've checked this locally, works fine. If you merge, it should auto-deploy within a few mins. (You can check by viewing URLs that the images embedded within the pages are served from).

When checking the live site, you might want to look at https://wellcomelibrary-alpha.herokuapp.com (as that by-passes the CDN caching-layer).

This might be a good page to test, as it has loads of thumbnails on it: http://wellcomelibrary-alpha.herokuapp.com/collections/aids or http://wellcomelibrary-alpha.herokuapp.com/b20086040

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

jennpb commented 8 years ago

@frankieroberto @george08 @tomcrane WOO! did it. It's all working. And it's pretty dang fast.