search

wellcomecollection / concepts-pipeline

Some sort of ETL pipeline for concepts in the Wellcome Collection catalogue
MIT License
0 stars 0 forks source link

extract ontologyType from catalogue concepts #79

Closed paul-butcher closed 2 years ago

paul-butcher commented 2 years ago

This will require a new index (or to update the. mappings on the existing one) before it will work in real life.

paul-butcher commented 2 years ago

Do we need to call the JSON field type, or could we call it ontologyType to match the Scala (and reduce overloading)?

I had started calling it ontologyType, then I noticed it was type elsewhere, so changed it to match. I'll make it ontologyType instead.

jamieparkinson commented 2 years ago

Is it worth renaming type to ontologyType in the Concept mapping too then? Although there will still be an inconsistency as type is what we want to expose in the API, and I was hoping that for the first pass the Concepts could be returned by the API as-is