wellcomecollection / content-api

📖 The API + ETL pipeline for searching the Wellcome Collection Prismic Repository.
MIT License
0 stars 0 forks source link

nextOpeningDates start at and include today #126

Closed agnesgaroux closed 6 months ago

agnesgaroux commented 6 months ago

What does this change?

Following the discovery of a bug in the itemsAPI, we realised there was a mismatch between the content-api's venues response, and the way the itemsAPI was using it, ie. content-api starting the list of openingTimes at today+1 while itemsAPI assuming it started at "today" https://wellcome.slack.com/archives/C02ANCYL90E/p1714748440989459 It was decided that the content-api should respond with a list of openingTimes that start with "today" if today is an open day

How to test

Running the api locally, hit http://localhost:3000/venues?title=library and check the nextOpeningDates start at today if today is an open day

How can we measure success?

Have we considered potential risks?

ItemsAPI is the only client of this endpoint. There will be checks there and in weco.org before this change is used by live systems