search

wellcomecollection / identity

Identity services for Wellcome Collection users
MIT License
0 stars 2 forks source link

implement a generic updatePatron method #326

Closed melanierogan closed 2 years ago

melanierogan commented 2 years ago

This can take options like barcode and varFieldTags to change patron details via PUT.

Based on https://github.com/wellcomecollection/wellcomecollection.org/issues/8073 and suggestion from @jamieparkinson here https://github.com/wellcomecollection/wellcomecollection.org/issues/8073#issuecomment-1156277878 and overall related to https://github.com/wellcomecollection/wellcomecollection.org/issues/7896

melanierogan commented 2 years ago

How hard would it be to roll together the other mutator methods?

  • updatePatronEmail
  • updatePassword

I think markPatronEmailVerified is sufficiently different in behaviour that it can/should stay separate

I think password pretty quick and patron email i'll just have to have another look at but can't immediately see why not. Please hold - more code deletion to come 🎵

melanierogan commented 2 years ago

I've got updatePassword rolled in, updateEmail is a little more tricky as it GETs record number, then PUTs an updated email and adds a note.