search

wellcomecollection / identity

Identity services for Wellcome Collection users
MIT License
0 stars 2 forks source link

Make sure users can't complete sign up if they don't accept the T&Cs #339

Open alexwlchan opened 2 years ago

alexwlchan commented 2 years ago

There's a TODO comment here that suggests we might not be doing that: https://github.com/wellcomecollection/identity/blob/fce8df936ae21572ca77c9f8900a1caaf2ff3809/packages/apps/auth0-actions/src/redirect_to_full_registration.ts#L12

I want to double check it and update that TODO.

alexwlchan commented 2 years ago

Testing this, it looks like we have client-side validation that you can't submit the form. I want to double-check that's validated on the server-side (and maybe recorded in Sierra?).