wellcomecollection / platform-infrastructure

:building_construction: Infrastructure for the Wellcome Digital Platform
MIT License
24 stars 8 forks source link

Remove healthcheck endpoints from nginx configuration for frontend #413

Closed kenoir closed 7 months ago

kenoir commented 7 months ago

What's changing and why?

This change removes the healthcheck endpoints from the frontend and frontend_identity docker images so these can now reach the app containers which serve there own healthchecks.

We also update the publish scripts to be a bit neater and use functions.

See https://github.com/wellcomecollection/wellcomecollection.org/issues/10545 for the motivation for this change.

In order to use this change, we should:

How to test

How can we measure success?

Healthchecks that really test if the application is running protect us from broken deployments going out, and ensure the application container is really serving requests when marked as healthy.