wellcomecollection / platform-infrastructure

:building_construction: Infrastructure for the Wellcome Digital Platform
MIT License
24 stars 8 forks source link

Remove AWS ChatBot permissions #428

Closed kenoir closed 7 months ago

kenoir commented 7 months ago

What's changing and why?

This change removes permissions used in the past to post to Slack by the AWS ChatBot service. We no longer use it, and the things publishing to topics associated with it no longer exist.

terraform plan diff

Terraform will perform the following actions:

  # aws_iam_role.catalogue_chatbot will be destroyed
  # (because aws_iam_role.catalogue_chatbot is not in configuration)
  - resource "aws_iam_role" "catalogue_chatbot" {
      - arn                   = "arn:aws:iam::756629837203:role/catalogue-chatbot" -> null
      - assume_role_policy    = jsonencode(
            {
              - Statement = [
                  - {
                      - Action    = "sts:AssumeRole"
                      - Effect    = "Allow"
                      - Principal = {
                          - Service = "chatbot.amazonaws.com"
                        }
                      - Sid       = ""
                    },
                ]
              - Version   = "2012-10-17"
            }
        ) -> null
      - create_date           = "2020-09-07T12:35:54Z" -> null
      - force_detach_policies = false -> null
      - id                    = "catalogue-chatbot" -> null
      - managed_policy_arns   = [] -> null
      - max_session_duration  = 3600 -> null
      - name                  = "catalogue-chatbot" -> null
      - path                  = "/" -> null
      - tags                  = {} -> null
      - tags_all              = {
          - "Department"                = "Digital Platform"
          - "Division"                  = "Culture and Society"
          - "Environment"               = "Production"
          - "TerraformConfigurationURL" = "https://github.com/wellcomecollection/platform-infrastructure/tree/main/monitoring/terraform"
          - "Use"                       = "Monitoring"
        } -> null
      - unique_id             = "AROA3AKVHCWJYXRL2ZALE" -> null

      - inline_policy {
          - name   = "terraform-20200907123554893300000001" -> null
          - policy = jsonencode(
                {
                  - Statement = [
                      - {
                          - Action   = [
                              - "sns:List*",
                              - "sns:Get*",
                              - "logs:TestMetricFilter",
                              - "logs:List*",
                              - "logs:Get*",
                              - "logs:FilterLogEvents",
                              - "logs:Describe*",
                              - "cloudwatch:List*",
                              - "cloudwatch:Get*",
                              - "cloudwatch:Describe*",
                              - "autoscaling:Describe*",
                            ]
                          - Effect   = "Allow"
                          - Resource = "*"
                          - Sid      = ""
                        },
                    ]
                  - Version   = "2012-10-17"
                }
            ) -> null
        }
    }

  # aws_iam_role_policy.catalogue_chatbot will be destroyed
  # (because aws_iam_role_policy.catalogue_chatbot is not in configuration)
  - resource "aws_iam_role_policy" "catalogue_chatbot" {
      - id     = "catalogue-chatbot:terraform-20200907123554893300000001" -> null
      - name   = "terraform-20200907123554893300000001" -> null
      - policy = jsonencode(
            {
              - Statement = [
                  - {
                      - Action   = [
                          - "sns:List*",
                          - "sns:Get*",
                          - "logs:TestMetricFilter",
                          - "logs:List*",
                          - "logs:Get*",
                          - "logs:FilterLogEvents",
                          - "logs:Describe*",
                          - "cloudwatch:List*",
                          - "cloudwatch:Get*",
                          - "cloudwatch:Describe*",
                          - "autoscaling:Describe*",
                        ]
                      - Effect   = "Allow"
                      - Resource = "*"
                      - Sid      = ""
                    },
                ]
              - Version   = "2012-10-17"
            }
        ) -> null
      - role   = "catalogue-chatbot" -> null
    }

Plan: 0 to add, 0 to change, 2 to destroy.
jamieparkinson commented 7 months ago

🗑️