wellcomecollection / platform-infrastructure

:building_construction: Infrastructure for the Wellcome Digital Platform
MIT License
24 stars 8 forks source link

increased memory from 128 (default) to 256 #444

Closed georgiaewhitney closed 1 month ago

georgiaewhitney commented 1 month ago

What's changing and why?

Memory increased from 128 (default var) to 256 as per #443

terraform plan diff

Terraform used the selected providers to generate the following execution plan. Resource actions are
indicated with the following symbols:
  ~ update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # aws_iam_role_policy.allow_s3_read must be replaced
-/+ resource "aws_iam_role_policy" "allow_s3_read" {
      ~ id          = "lambda_send_slack_alert_for_5xx_errors:terraform-20230321122311397500000001" -> (known after apply)
      ~ name        = "terraform-20230321122311397500000001" -> (known after apply)
      - name_prefix = "terraform-" -> null # forces replacement
        # (2 unchanged attributes hidden)
    }

  # module.slack_alerts_for_5xx.aws_lambda_function.lambda_function will be updated in-place
  ~ resource "aws_lambda_function" "lambda_function" {
        id                             = "send_slack_alert_for_5xx_errors"
      ~ last_modified                  = "2024-07-19T08:22:17.000+0000" -> (known after apply)
      ~ memory_size                    = 128 -> 256
      ~ source_code_hash               = "jsduuStdqBOd39Sw6YQfq1KAsEy5OzA2f4gZUEfxUdI=" -> "Muyhd941OhW1yIHHSbtKNyrHywvymTj0LntBt9NxVsE="
        tags                           = {}
        # (25 unchanged attributes hidden)

        # (4 unchanged blocks hidden)
    }

Plan: 1 to add, 1 to change, 1 to destroy.
georgiaewhitney commented 1 month ago

Thanks for this, @StepanBrychta! This is really well explained and the approach you've suggested makes a lot of sense - I'll make these changes.