wellcomecollection / platform

Wellcome Collection Digital Platform
https://developers.wellcomecollection.org/
MIT License
47 stars 10 forks source link

Outstanding DDS migration issues #3957

Closed kenoir closed 4 years ago

kenoir commented 4 years ago

These are some outstanding issues identified by Ashley with items migrated to DDS:

Need resolving:

Migrated (Maybe bagger/DDS):

New (Maybe Goobi/DDS):

We need to ensure these issues have been addressed and resolved.

aray-wellcome commented 4 years ago

@alexwlchan I was looking around at b17729555 and some other archives stuff. I think I was wrong about the pre-fix because b11916576 has a file without the bnumber pre-fix and is working just fine in DDS and on live UV. However, b17729555 does have filenames with a space in them instead of an underscore...so maybe it's that. image

alexwlchan commented 4 years ago

I’m going to punt b17729555 back to Digirati.

The IIIF manifest refers to an identifier b17729555_PP_AEM_K 179_0001.jp2. https://wellcomelibrary.org/iiif/b17729555/manifest

If you query https://api.dlcs.io/customers/2/spaces/5/images/b17729555_PP_AEM_K%20179_0001.jp2, you see that it knows where to find that image:

  "origin": "https://s3-eu-west-1.amazonaws.com/wellcomecollection-storage/digitised/b17729555/v1/data/objects/PP_AEM_K 179_0001.jp2",

(Notice this key correctly omits a b17729555_ prefix.)

That URI does point to an object in the storage service, aka the JP2 in question. If you ask the storage service, you'll get that image back. I'm pretty sure Tom Crane has said DLCS/DDS can cope with spaces in filenames, so I'm not sure what's happening here.

tomcrane commented 4 years ago

b17729555 isn't displaying on the library website

I think was fixed by @fractos applying the space in identifier support the images pathway on 7 Nov. It's working for me on the site - the only place it doesn't work is when you hover over the thumbnail image in the dashboard view - that should present a larger thumbnail, but it doesn't, it appears broken. This is using a bootstrap tooltip component that is getting confused by the missing space.

I'll see if I can fix that.

tomcrane commented 4 years ago

OK, thumbnail dashboard issue fixed for b17729555

tomcrane commented 4 years ago

b17307922 - this isn't a poster image issue at all - I was getting confused by earlier mentions of JP2s in the bag.

Its poster image is working just fine - here it is:

https://wellcomelibrary.org/posterimages/b17307922/0056-0000-4402-0102-0-0000-0000-0.jpg

This uses the new model - but this is an old, migrated example. The problem is that the MP3 in storage isn't an MP3 - it's that book cover. I thought all those had been re-bagged, but maybe this one was missed because it's not an image (not supposed to be an image). So there was a JP2 in the bag, even if it was trying to pass itself off as an MP3.

alexwlchan commented 4 years ago

Florence is chatting again, so we're done! 🎉