wellcomecollection / platform

Wellcome Collection Digital Platform
https://developers.wellcomecollection.org/
MIT License
48 stars 10 forks source link

Stop hierarchies from displaying when they shouldn't #5714

Closed pollecuttn closed 1 year ago

pollecuttn commented 1 year ago

First reported on 27 July:

I've just realised that if you add a 773 to a Collection level record in Sierra it automatically creates a hierarchy: https://wellcomecollection.org/works/kd7vg53h. I thought it required reciprocal 774 fields, but clearly not - this is amazing thank you! cant tell you how much time/effort it could save OH!!! it has literally just disappeared! But Nic saw it if you want verification!

And again on 2 August:

a phantom hierarchy is displaying again for this collection! https://wellcomecollection.org/works/kd7vg53h The records are using a MARC 773, which I understood acts as a series. Last week it listed all 500+ items, those vanished, now it is displaying a hierarchy for items that had their records edited yesterday, but not the rest of the collection. Rada Vlatkovic is making them closed access. Is it just the system taking time to catch up with itself?

Possibly something to do with the order in which Sierra records are edited?

Done when

paul-butcher commented 1 year ago

This is caused by the 773 at the top level. This is making the root document behave like a branch. Once it gets to the relation embedder, it can't tell the difference. I have a candidate solution I can put in (don't add it if the $773 matches $1 in the same document), but it can also be fixed in the data by not having that self-referential 773s.

paul-butcher commented 1 year ago

Fixed and on main, pending a reindex.