We definitely used to support this, because we have Miro bags that have spaces in the external identifier/keys. You could make an argument that we shouldn't support this, but there's historical precedent for it and S3 is fine with it, so this patch adds support and proper test coverage for this case.
(In unsurprising news, the bug was in S3Resolvable, a class we thought was simple enough not to require tests – oops.)
This fixes a small regression; we need this bugfix for https://github.com/wellcomecollection/platform/issues/5708
We definitely used to support this, because we have Miro bags that have spaces in the external identifier/keys. You could make an argument that we shouldn't support this, but there's historical precedent for it and S3 is fine with it, so this patch adds support and proper test coverage for this case.
(In unsurprising news, the bug was in S3Resolvable, a class we thought was simple enough not to require tests – oops.)