wellcomecollection / storage-service

🗃️ Managing the safe, long-term storage of our digital collections in the cloud
MIT License
31 stars 5 forks source link

log into ECR with get-login-password #1112

Closed kenoir closed 5 months ago

kenoir commented 5 months ago

What does this change?

This fixes another example of the problem found in https://github.com/wellcomecollection/archivematica-infrastructure/pull/141

See https://buildkite.com/wellcomecollection/storage-service/builds/1691

How to test

Open a PR and see whether the PR checks pass.

How can we measure success?

We can build the storage service again.

Have we considered potential risks?

This has been applied successfully in other project. We can also check it works properly before even merging the change. The build here also signs into ecr public so we might see the problem pop up in another place too.