wellcomecollection / storage-service

🗃️ Managing the safe, long-term storage of our digital collections in the cloud
MIT License
31 stars 5 forks source link

Adds a simple healthcheck endpoint to the bags and ingest apis #1115

Closed kenoir closed 5 months ago

kenoir commented 5 months ago

What does this change?

This change is part of https://github.com/wellcomecollection/wellcomecollection.org/issues/10545, and adds an HTTP healthcheck to the bags and ingest APsI to ensure the scala service has started before it is registered healthy at the NLB and starts serving requests.

Depends: https://github.com/wellcomecollection/storage-service/pull/1114

How to test?

How can we measure success?

No downtime during deployments resulting in a better experience for consumers of this service, and fewer errors that we cannot effectively respond to in the alerts channel.

Have we considered potential risks?

Changing the health-checks changes the failure modes for the API, although we have tested this principle successfully in lots of other places so the risk is reduced.